From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiwei Bie Subject: [PATCH] net/virtio-user: strip VIRTIO_NET_F_MAC when MAC isn't specified Date: Fri, 11 May 2018 18:55:42 +0800 Message-ID: <20180511105542.18395-1-tiwei.bie@intel.com> Cc: dev@dpdk.org To: maxime.coquelin@redhat.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 37EE17D00 for ; Fri, 11 May 2018 12:55:13 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently VIRTIO_NET_F_MAC is set unconditionally when server mode is used. It should be stripped when MAC isn't specified. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c index 38b8bc90d..d31f895f2 100644 --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c @@ -378,6 +378,8 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, if (dev->mac_specified) dev->device_features |= (1ull << VIRTIO_NET_F_MAC); + else + dev->device_features &= ~(1ull << VIRTIO_NET_F_MAC); if (cq) { /* device does not really need to know anything about CQ, -- 2.11.0