From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: [PATCH v2] log: fix pattern matching Date: Wed, 16 May 2018 15:09:28 +0100 Message-ID: <20180516140928.76570-1-ferruh.yigit@intel.com> References: <20180516140523.75519-1-ferruh.yigit@intel.com> Cc: dev@dpdk.org, Ferruh Yigit , stephen@networkplumber.org To: Thomas Monjalon Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DF0151B016 for ; Wed, 16 May 2018 16:09:51 +0200 (CEST) In-Reply-To: <20180516140523.75519-1-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" loglevel set wrong when ":" is used as separator, like --log-type="user:debug" This is because fnmatch returns zero on success. Fixed fnmatch return value check. Fixes: 7f0bb634a140 ("log: add ability to match log type with globbing") Cc: stephen@networkplumber.org Signed-off-by: Ferruh Yigit --- v2: * s/seperator/separator/ in commit log --- lib/librte_eal/common/eal_common_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index c660ca659..818118944 100644 --- a/lib/librte_eal/common/eal_common_log.c +++ b/lib/librte_eal/common/eal_common_log.c @@ -184,7 +184,7 @@ rte_log_set_level_pattern(const char *pattern, uint32_t level) if (rte_logs.dynamic_types[i].name == NULL) continue; - if (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0)) + if (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0) == 0) rte_logs.dynamic_types[i].loglevel = level; } -- 2.14.3