From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v4 07/23] rte_ring.h: remove signed type
 flipflopping
Date: Thu, 17 May 2018 10:29:57 +0200
Message-ID: <20180517082957.4jhfjsb24tww6lhs@glumotte.dev.6wind.com>
References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain>
 <152627460274.53156.14436567362656342224.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 7AF605942
 for <dev@dpdk.org>; Thu, 17 May 2018 10:30:11 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <152627460274.53156.14436567362656342224.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 14, 2018 at 01:10:02PM +0800, Andy Green wrote:
> /projects/lagopus/src/dpdk/build/include/rte_ring.h:350:46:
> warning: conversion to 'uint32_t' {aka 'unsigned int'}
> from 'int' may change the sign of the result
> [-Wsign-conversion]
>   update_tail(&r->prod, prod_head, prod_next, is_sp, 1);
> 
> The visible apis take unsigned int, then call a private
> api taking an int, which finally calls an api taking an
> unsigned int.
> 
> Convert the private api to take unsigned int removing
> 5 x warning similar to that shown above.
> 
> Signed-off-by: Andy Green <andy@warmcat.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>