From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 01/23] lib/librte_eal: import libbsd
	strlcpy
Date: Thu, 17 May 2018 11:36:58 +0100
Message-ID: <20180517103658.GA16984@bricha3-MOBL.ger.corp.intel.com>
References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain>
 <152627457252.53156.7037125685610031955.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id B48051DA4
 for <dev@dpdk.org>; Thu, 17 May 2018 12:37:02 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <152627457252.53156.7037125685610031955.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 14, 2018 at 01:09:32PM +0800, Andy Green wrote:
> Signed-off-by: Andy Green <andy@warmcat.com>
> ---
>  lib/librte_eal/common/eal_common_string_fns.c  |   34 ++++++++++++++++++++++++
>  lib/librte_eal/common/include/rte_string_fns.h |    7 +----
>  2 files changed, 36 insertions(+), 5 deletions(-)
> 

While I'm aware this was suggested by other reviewers, I really don't feel
that it is necessary to actually import the code. If libbsd is present on
the system, we will use it directly. If libbsd is not present, the snprintf
provides an acceptable fallback for strlcpy IMHO. Having the full function
without good justification seems excessive.

/Bruce