From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v4] vhost: improve dirty pages logging
	performance
Date: Thu, 17 May 2018 20:13:01 +0800
Message-ID: <20180517121301.GA22907@debian>
References: <20180517114447.28205-1-maxime.coquelin@redhat.com>
 <81a73714-9a7f-0b64-d508-2eb03422fe06@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: dev@dpdk.org, mst@redhat.com, stable@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <81a73714-9a7f-0b64-d508-2eb03422fe06@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, May 17, 2018 at 02:01:52PM +0200, Maxime Coquelin wrote:
> Hi Tiwei,
> 
> On 05/17/2018 01:44 PM, Maxime Coquelin wrote:
> > This patch caches all dirty pages logging until the used ring index
> > is updated.
> > 
> > The goal of this optimization is to fix a performance regression
> > introduced when the vhost library started to use atomic operations
> > to set bits in the shared dirty log map. While the fix was valid
> > as previous implementation wasn't safe against concurrent accesses,
> > contention was induced.
> > 
> > With this patch, during migration, we have:
> > 1. Less atomic operations as only a single atomic OR operation
> > per 32 or 64 (depending on CPU) pages.
> > 2. Less atomic operations as during a burst, the same page will
> > be marked dirty only once.
> > 3. Less write memory barriers.
> > 
> > Fixes: 897f13a1f726 ("vhost: make page logging atomic")
> > 
> > Cc:stable@dpdk.org
> > 
> > Cc: Tiwei Bie<tiwei.bie@intel.com>
> > Suggested-by: Michael S. Tsirkin<mst@redhat.com>
> > Signed-off-by: Maxime Coquelin<maxime.coquelin@redhat.com>
> 
> I missed to add your:
> Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> 
> that you replied to v3, and since the changes in v4 were suggested by
> you, I guess it still applies.

Yeah. Thanks! :)

Best regards,
Tiwei Bie