From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: [PATCH] eal: fix directory permissions Date: Fri, 18 May 2018 15:55:35 +0200 Message-ID: <20180518135437.30692-1-adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Anatoly Burakov Return-path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 4134BD0C9 for ; Fri, 18 May 2018 15:55:51 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id w194-v6so14217388wmf.2 for ; Fri, 18 May 2018 06:55:51 -0700 (PDT) Content-Disposition: inline List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Executable bit must be set on directories for normal users to enter them. This patch addresses the inability to start DPDK applications as non-root due to errors such as: EAL: failed to bind /tmp/dpdk/rte/mp_socket: Permission denied Fixes: 56236363b481 ("eal: add directory for runtime data") Cc: Anatoly Burakov Signed-off-by: Adrien Mazarguil --- lib/librte_eal/bsdapp/eal/eal.c | 4 ++-- lib/librte_eal/linuxapp/eal/eal.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c index 7f8475eac..dc279542d 100644 --- a/lib/librte_eal/bsdapp/eal/eal.c +++ b/lib/librte_eal/bsdapp/eal/eal.c @@ -123,14 +123,14 @@ eal_create_runtime_dir(void) /* create the path if it doesn't exist. no "mkdir -p" here, so do it * step by step. */ - ret = mkdir(tmp, 0600); + ret = mkdir(tmp, 0700); if (ret < 0 && errno != EEXIST) { RTE_LOG(ERR, EAL, "Error creating '%s': %s\n", tmp, strerror(errno)); return -1; } - ret = mkdir(runtime_dir, 0600); + ret = mkdir(runtime_dir, 0700); if (ret < 0 && errno != EEXIST) { RTE_LOG(ERR, EAL, "Error creating '%s': %s\n", runtime_dir, strerror(errno)); diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 150d5dd13..8655b8691 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -131,14 +131,14 @@ eal_create_runtime_dir(void) /* create the path if it doesn't exist. no "mkdir -p" here, so do it * step by step. */ - ret = mkdir(tmp, 0600); + ret = mkdir(tmp, 0700); if (ret < 0 && errno != EEXIST) { RTE_LOG(ERR, EAL, "Error creating '%s': %s\n", tmp, strerror(errno)); return -1; } - ret = mkdir(runtime_dir, 0600); + ret = mkdir(runtime_dir, 0700); if (ret < 0 && errno != EEXIST) { RTE_LOG(ERR, EAL, "Error creating '%s': %s\n", runtime_dir, strerror(errno)); -- 2.11.0