From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] eventdev: remove ethdev Rx adapter event type Date: Sun, 20 May 2018 22:51:05 +0530 Message-ID: <20180520172104.GA6224@jerin> References: <20180520164843.4386-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nikhil Rao To: dev@dpdk.org Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0044.outbound.protection.outlook.com [104.47.41.44]) by dpdk.org (Postfix) with ESMTP id B88F38D94 for ; Sun, 20 May 2018 19:21:26 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180520164843.4386-1-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Sun, 20 May 2018 22:18:43 +0530 > From: Jerin Jacob > To: dev@dpdk.org > Cc: Jerin Jacob , Nikhil Rao > > Subject: [dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type > X-Mailer: git-send-email 2.17.0 > > The initial thought was to create a separate event type > for each adapter, in order to make consistency with > new event adapters, remove RTE_EVENT_TYPE_ETH_RX_ADAPTER > event type and use RTE_EVENT_TYPE_ETHDEV event type instead > like other event adapters. > > Cc: Nikhil Rao > Signed-off-by: Jerin Jacob Self - NACK. external PCIe NW cards + HW eventdev case will failing this case, as RTE_EVENT_TYPE_ETHDEV identifier was used for converting to mbuf in eventdev_dequeue case. > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- > lib/librte_eventdev/rte_eventdev.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > index 6f7050952..8b9887b3d 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -468,7 +468,7 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter, > ev->op = RTE_EVENT_OP_NEW; > ev->sched_type = sched_type; > ev->queue_id = qid; > - ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > + ev->event_type = RTE_EVENT_TYPE_ETHDEV; > ev->sub_event_type = 0; > ev->priority = priority; > ev->mbuf = m; > diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h > index b6fd6ee7f..cef0a55d8 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -948,8 +948,6 @@ rte_event_dev_close(uint8_t dev_id); > /**< The event generated from cpu for pipelining. > * Application may use *sub_event_type* to further classify the event > */ > -#define RTE_EVENT_TYPE_ETH_RX_ADAPTER 0x4 > -/**< The event generated from event eth Rx adapter */ > #define RTE_EVENT_TYPE_MAX 0x10 > /**< Maximum number of event types */ > > -- > 2.17.0 >