From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var Date: Sun, 20 May 2018 23:55:40 -0700 Message-ID: <20180520235540.597588e8@xeon-e3> References: <1526865655-59863-1-git-send-email-ych@panath.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: shijith.thotton@cavium.com, dev@dpdk.org To: yaochuhong Return-path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 082E39605 for ; Mon, 21 May 2018 08:55:43 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id w129-v6so6616122pfd.3 for ; Sun, 20 May 2018 23:55:42 -0700 (PDT) In-Reply-To: <1526865655-59863-1-git-send-email-ych@panath.cn> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 21 May 2018 09:20:53 +0800 yaochuhong wrote: > Signed-off-by: yaochuhong > --- > drivers/net/liquidio/lio_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > old mode 100644 > new mode 100755 > index 0e0b5d8..bd47911 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -1405,6 +1405,12 @@ struct rte_lio_xstats_name_off { > /* Configure RSS if device configured with multiple RX queues. */ > lio_dev_mq_rx_configure(eth_dev); > > + /* Before update the link info, set link_status64 to 0, > + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, > + * and lio_dev->intf_open will be set to 0. > + */ > + lio_dev->linfo.link.link_status64 = 0; > + > /* start polling for lsc */ > ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT, > lio_sync_link_state_check, Your mail system or editor is converting tabs to spaces. Please run checkpatch on your submissions. ### [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #88: FILE: drivers/net/liquidio/lio_ethdev.c ERROR:TRAILING_WHITESPACE: trailing whitespace #97: FILE: drivers/net/liquidio/lio_ethdev.c:1409: + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, $ WARNING:LONG_LINE_COMMENT: line over 80 characters #97: FILE: drivers/net/liquidio/lio_ethdev.c:1409: + * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, WARNING:LEADING_SPACE: please, no spaces at the start of a line #100: FILE: drivers/net/liquidio/lio_ethdev.c:1412: + lio_dev->linfo.link.link_status64 = 0;$ ERROR:TRAILING_WHITESPACE: trailing whitespace #101: FILE: drivers/net/liquidio/lio_ethdev.c:1413: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: drivers/net/liquidio/lio_ethdev.c:1413: + $ total: 3 errors, 3 warnings, 0 checks, 12 lines checked