From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] lib/librte_eal: change type of tmp
Date: Mon, 21 May 2018 13:07:52 +0100
Message-ID: <20180521120751.GA22944@bricha3-MOBL.ger.corp.intel.com>
References: <152686805827.58694.11447559809199835902.stgit@localhost.localdomain>
 <152690080971.12755.9675572999031608037.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id BC2C51DB8
 for <dev@dpdk.org>; Mon, 21 May 2018 14:07:57 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <152690080971.12755.9675572999031608037.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 21, 2018 at 07:06:49PM +0800, Andy Green wrote:
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47'
>   MOVEUNALIGNED_LEFT47(dst, src, n, srcofs);
>   ^~~~~~~~~~~~~~~~~~~~
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 649:51: warning: conversion from 'size_t' {aka 'long
> unsigned int'} to 'int' may change value [-Wconversion]
>      case 0x0B: MOVEUNALIGNED_LEFT47_IMM(dst, src,
> n, 0x0B); break;    \
>                                                    ^
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 616:15: note: in definition of macro 'MOVEUNALIGNED_LEFT47_IMM'
>          tmp = len;                                                                                          \
>                ^~~
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47'
>   MOVEUNALIGNED_LEFT47(dst, src, n, srcofs);
>   ^~~~~~~~~~~~~~~~~~~~
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 618:13: warning: conversion to 'size_t' {aka 'long
> unsigned int'} from 'int' may change the sign of the
> result [-Wsign-conversion]
>          tmp -= len;                                                                                         \
>              ^~
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 649:16: note: in expansion of macro 'MOVEUNALIGNED_LEFT47_IMM'
>      case 0x0B: MOVEUNALIGNED_LEFT47_IMM(dst, src,
> n, 0x0B); break;    \
>                 ^~~~~~~~~~~~~~~~~~~~~~~~
> /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
> 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47'
>   MOVEUNALIGNED_LEFT47(dst, src, n, srcofs);
>   ^~~~~~~~~~~~~~~~~~~~
> 
>     /projects/lagopus/src/dpdk/build/include/rte_memcpy.h:
>     618:13: warning: conversion to 'size_t' {aka 'long
>     unsigned int'} from 'int' may change the sign of the
>     result [-Wsign-conversion]
>              tmp -= len;
>                  ^~
> 
> We can eliminate the problems by setting the type of tmp to
> size_t in the first place.
> 
> After a suggestion by Bruce Richardson
> 
> Signed-off-by: Andy Green <andy@warmcat.com>
> Fixes: d35cc1fe6a ("eal/x86: revert select optimized memcpy at run-time")
> ---

Thanks, this looks a better fix than loads of type-casting.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>