From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v6 4/8] rte_mbuf.h: reduce temp to match
 uint16 types
Date: Mon, 21 May 2018 13:14:34 +0100
Message-ID: <20180521121434.GD22944@bricha3-MOBL.ger.corp.intel.com>
References: <152686781484.58694.14737673447518527445.stgit@localhost.localdomain>
 <152686807337.58694.8171528630879404747.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id DBA8A1B03D
 for <dev@dpdk.org>; Mon, 21 May 2018 14:14:38 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <152686807337.58694.8171528630879404747.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 21, 2018 at 10:01:13AM +0800, Andy Green wrote:
>     /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
>     In function 'rte_pktmbuf_detach':
>     /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
>     1583:17: warning: conversion from 'uint32_t' {aka
>     'unsigned int'} to 'uint16_t' {aka
>     'short unsigned int'} may change value [-Wconversion]
>       m->priv_size = priv_size;
>                      ^~~~~~~~~
> 
>     The temp priv_size is declared as a uint32_t.  But it
>     only deals in uint16_t.  m->priv_size is a uint16_t.
>     Change it to a uint16_t.
> 
> Fixes: 355e6735b3 ("mbuf: fix cloning with private mbuf data")
> Fixes: 1a60a0daa6 ("mbuf: fix segments number type increase")
> Signed-off-by: Andy Green <andy@warmcat.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>