From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo de Lara Subject: [PATCH v5 4/6] doc: announce deprecation in crypto queue pair start/stop Date: Mon, 21 May 2018 14:08:39 +0100 Message-ID: <20180521130841.40219-5-pablo.de.lara.guarch@intel.com> References: <20180126090355.25903-1-pablo.de.lara.guarch@intel.com> <20180521130841.40219-1-pablo.de.lara.guarch@intel.com> Cc: dev@dpdk.org, Pablo de Lara To: declan.doherty@intel.com, akhil.goyal@nxp.com, shally.verma@cavium.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 997B51B022 for ; Mon, 21 May 2018 15:08:28 +0200 (CEST) In-Reply-To: <20180521130841.40219-1-pablo.de.lara.guarch@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Functions rte_cryptodev_queue_pair_start/stop are not really used in any of the crypto drivers (they all just return 0 or -ENOTSUP). Therefore, this API can be deprecated from 18.05 and removed in 18.08. Signed-off-by: Pablo de Lara Acked-by: Akhil Goyal Acked-by: Fiona Trahe --- doc/guides/rel_notes/deprecation.rst | 4 ++++ lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index b5d1cc0d5..66168812c 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -84,3 +84,7 @@ Deprecation Notices ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from 18.05 and removed in 18.08, as there are no drivers doing anything useful with them. + - Functions ``rte_cryptodev_queue_pair_start()`` and + ``rte_cryptodev_queue_pair_stop()`` will be deprecated from 18.05 + and removed in 18.08, as there are no drivers doing anything useful + with them. diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index efd3270e5..db367a1f8 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -602,6 +602,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, struct rte_mempool *session_pool); /** + * @deprecated * Start a specified queue pair of a device. It is used * when deferred_start flag of the specified queue is true. * @@ -615,10 +616,12 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id, * - -EINVAL: The dev_id or the queue_id out of range. * - -ENOTSUP: The function not supported in PMD driver. */ +__rte_deprecated extern int rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id); /** + * @deprecated * Stop specified queue pair of a device * * @param dev_id The identifier of the device @@ -631,6 +634,7 @@ rte_cryptodev_queue_pair_start(uint8_t dev_id, uint16_t queue_pair_id); * - -EINVAL: The dev_id or the queue_id out of range. * - -ENOTSUP: The function not supported in PMD driver. */ +__rte_deprecated extern int rte_cryptodev_queue_pair_stop(uint8_t dev_id, uint16_t queue_pair_id); -- 2.17.0