From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v3] ether: use a default for max Rx frame size in configure() Date: Wed, 23 May 2018 10:53:35 +0530 Message-ID: <20180523052333.GA12257@jerin> References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1719643.qo6JmGv4pL@xps> <7564896.sbN2ypR4X7@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , Andriy Berestovskyy , "dev@dpdk.org" , Bruce Richardson , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "jerin.jacob@cavium.com" To: Shahaf Shuler Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0051.outbound.protection.outlook.com [104.47.42.51]) by dpdk.org (Postfix) with ESMTP id E7996239 for ; Wed, 23 May 2018 07:23:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Wed, 23 May 2018 05:21:43 +0000 > From: Shahaf Shuler > To: Thomas Monjalon , Andriy Berestovskyy > > CC: "dev@dpdk.org" , Bruce Richardson > , "ferruh.yigit@intel.com" > , "arybchenko@solarflare.com" > , "hemant.agrawal@nxp.com" > , "jerin.jacob@cavium.com" > > Subject: RE: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame > size in configure() > > Hi Andriy, > > I think this patch addressing just small issue in a bigger problem. > The way I see it all application needs to specify is the max packet size it expects to receive, nothing else(!). +1 > Currently we are forcing it to toggle multiple redundant fields.