From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] eventdev: fix eth port in eth Rx adapter
 internal function
Date: Wed, 23 May 2018 11:21:20 +0530
Message-ID: <20180523055118.GA10924@jerin>
References: <1527023202-51808-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, stable@dpdk.org
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <1527023202-51808-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 23 May 2018 02:36:42 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] eventdev: fix eth port in eth Rx adapter internal function
> X-Mailer: git-send-email 1.8.3.1
> 
> The dev_id parameter to fill_event_buffer() should be 16 bit,
> also rename to to eth_dev_id to avoid confusion with event device
> id elsewhere in the file.
> 
> Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> Cc: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 6f70509..273df1e 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -418,14 +418,14 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b)
>  
>  static inline void
>  fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter,
> -	uint8_t dev_id,
> +	uint16_t eth_dev_id,
>  	uint16_t rx_queue_id,
>  	struct rte_mbuf **mbufs,
>  	uint16_t num)
>  {
>  	uint32_t i;
>  	struct eth_device_info *eth_device_info =
> -					&rx_adapter->eth_devices[dev_id];
> +					&rx_adapter->eth_devices[eth_dev_id];
>  	struct eth_rx_queue_info *eth_rx_queue_info =
>  					&eth_device_info->rx_queue[rx_queue_id];
>  
> -- 
> 1.8.3.1
>