From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhiyong.yang@intel.com Subject: [PATCH v2] net/virtio: fix add pointer checking for rxvq Date: Thu, 24 May 2018 23:51:01 +0800 Message-ID: <20180524155101.40911-1-zhiyong.yang@intel.com> References: <20180524130423.15554-1-zhiyong.yang@intel.com> Cc: stable@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, lei.a.yao@intel.com, ferruh.yigit@intel.com, Zhiyong Yang To: dev@dpdk.org Return-path: In-Reply-To: <20180524130423.15554-1-zhiyong.yang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For virtio-user server mode, one use case comes across segmentation fault. step 1: Launch vhost side as client firstly. step 2: launch virtio-user side as server. The cause is: after registering virtio_interrupt_handler into eal-intr-thread, two threads (main thread and eal-intr-thread) have sync issues, so add rxvq pointer checking in function virtio_notify_peers to decide if the code can continue. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: stable@dpdk.org Cc: maxime.coquelin@redhat.com Cc: tiwei.bie@intel.com Cc: lei.a.yao@intel.com Cc: ferruh.yigit@intel.com Signed-off-by: Zhiyong Yang Reviewed-by: Maxime Coquelin --- Change in V2: change title prefix from net/virtio-user to net/virtio. drivers/net/virtio/virtio_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 5833dad73..df50a571a 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1245,6 +1245,9 @@ virtio_notify_peers(struct rte_eth_dev *dev) return; rxvq = dev->data->rx_queues[0]; + if (!rxvq) + return; + rarp_mbuf = rte_net_make_rarp_packet(rxvq->mpool, (struct ether_addr *)hw->mac_addr); if (rarp_mbuf == NULL) { -- 2.14.3