From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4] devtools: add test script for meson builds
Date: Mon, 28 May 2018 10:39:18 +0100
Message-ID: <20180528093842.GC15204@bricha3-MOBL.ger.corp.intel.com>
References: <20180424123255.204330-1-bruce.richardson@intel.com>
 <20180526112142.9975-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 8C4E9200
 for <dev@dpdk.org>; Mon, 28 May 2018 11:39:22 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180526112142.9975-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, May 26, 2018 at 01:21:42PM +0200, Thomas Monjalon wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
> 
> To simplify testing with the meson and ninja builds, we can add a script
> to set up and do multiple builds. Currently this script sets up:
> 
> * clang and gcc builds
> * builds using static and shared linkage for binaries (libs are always
>    built as both)
> * a build using the lowest instruction-set level for x86 (-march=nehalem)
> * cross-builds for each cross-file listed in config/arm
> 
> Each build is configured in a directory ending in *-build, and then for
> the build stage, we just call ninja in each directory in turn. [i.e. we
> assume every directory starting with "build-" is a meson build, which is
> probably an ok assumption].
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: it is a rework with 3 major changes
>    - automatically stop on error thanks to -e
>    - directory name starts with "build-"
>    - optionally load a config file to get some environment variables
> v3:
>    - remove forcing "cd": use current directory
>    - remove CROSS: use hard-written aarch64-linux-gnu-gcc
>    - remove config load in script start
> v4:
>    - remove config file loading (will be improved and sent later)
>    - the v4 is closer to what Bruce sent as v1
> ---

Yes, it's closer, but there is also some good material in your v2 that we
probably want to rework into this later on. I suggest in the name of
progress we merge this version and iterate on improving it later.

/Bruce