From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v2] devtools: add test script for meson builds
Date: Tue, 29 May 2018 11:59:10 +0100
Message-ID: <20180529105910.GA4808@bricha3-MOBL.ger.corp.intel.com>
References: <20180424123255.204330-1-bruce.richardson@intel.com>
 <1832507.I1aXYWBlau@xps>
 <20180528132023.GB8752@bricha3-MOBL.ger.corp.intel.com>
 <3902265.nh2GMnEBpQ@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 4955C2B96
 for <dev@dpdk.org>; Tue, 29 May 2018 12:59:16 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <3902265.nh2GMnEBpQ@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 29, 2018 at 12:38:14PM +0200, Thomas Monjalon wrote:
> 28/05/2018 15:20, Bruce Richardson:
> > On Mon, May 28, 2018 at 12:26:24PM +0200, Thomas Monjalon wrote:
> > > 28/05/2018 11:33, Bruce Richardson:
> > > > On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote:
> > > > > 25/05/2018 17:18, Bruce Richardson:
> > > > > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > > > > > > +load_config () +{ +	reset_env +	. $(dirname $(readlink -e
> > > > > > > $0))/load-devel-config +	MESON=${MESON:-meson} +}
> > > > > > Why does this need to be done each time?
> > > > > 
> > > > > Because the config could be different for each build (see above).
> > > > > 
> > > > How would it be different, it's the same command called with the same
> > > > environment each time?
> > > 
> > > No, the idea is to adapt the environment to the build target.  As an
> > > example, the dependencies can be different for 32-bit and 64-bit.
> > > 
> > I would hope that dependency detection should solve that, but since you
> > already have support for that in existing build script via environment
> > vars, I have no objection to leveraging that in the meson scripts. Overall,
> > though, I'd prefer to ensure that the detection works so that everyone only
> > needs one environment setup in order to get all builds working
> > simultaneously.
> 
> The dependency detection cannot work if I have dependencies in uncommon
> directories.
> I think it is important to allow testing compilation with dependencies
> which are available but not installed, by providing paths.
> 
Yes, but that should be done via meson configure options to specify the
paths, rather than via environmental variables. AFAIK there is no support in
meson for querying the environment*, every variable that could affect the
build should be explicitly specified 

/Bruce

* Ok, no direct way. There are probably ways in which it could be done,
but it's not the meson way to do things.