From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2 1/2] mk: fix cross build
 errors
Date: Tue, 29 May 2018 16:00:08 +0100
Message-ID: <20180529150008.GA25480@bricha3-MOBL.ger.corp.intel.com>
References: <1527133127-29407-1-git-send-email-gavin.hu@arm.com>
 <1527490428-15540-1-git-send-email-gavin.hu@arm.com>
 <20180528132402.GC8752@bricha3-MOBL.ger.corp.intel.com>
 <3461471.4uoUW6OFvL@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Gavin Hu <gavin.hu@arm.com>, dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 12CAD2583
 for <dev@dpdk.org>; Tue, 29 May 2018 17:00:12 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <3461471.4uoUW6OFvL@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote:
> 28/05/2018 15:24, Bruce Richardson:
> > Would a simpler solution for this not be to put "-Wno-implicit-fallthrough"
> > for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno"
> > flag when compiling, unless there are other errors. This means we can just
> > use the flag without bothering with version checks.
> 
> No, it does not work.
> I have this error with clang 5.0.1:
> 	error: unknown warning option '-Wno-format-truncation'
> 
Yes, you still need to check for GCC to use the flag, just not for a
specific version of GCC.

/Bruce