From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v10 1/5] eal: add rte_uuid support
Date: Fri, 8 Jun 2018 11:11:54 -0700
Message-ID: <20180608111154.4a034010@xeon-e3>
References: <20180608165920.12228-1-stephen@networkplumber.org>
 <20180608165920.12228-2-stephen@networkplumber.org>
 <6F565A11-3B17-4A94-806C-3F066499AAD5@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger <sthemmin@microsoft.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67])
 by dpdk.org (Postfix) with ESMTP id 537B91BB4E
 for <dev@dpdk.org>; Fri,  8 Jun 2018 20:12:02 +0200 (CEST)
Received: by mail-pg0-f67.google.com with SMTP id l2-v6so6738806pgc.7
 for <dev@dpdk.org>; Fri, 08 Jun 2018 11:12:02 -0700 (PDT)
In-Reply-To: <6F565A11-3B17-4A94-806C-3F066499AAD5@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 8 Jun 2018 17:15:04 +0000
"Wiles, Keith" <keith.wiles@intel.com> wrote:

> > On Jun 8, 2018, at 9:59 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> > 
> > Since uuid functions may not be available everywhere, implement
> > uuid functions in DPDK. These are based off the BSD licensed
> > libuuid in util-link.
> > 
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > ---
> > lib/librte_eal/bsdapp/eal/Makefile       |   1 +
> > lib/librte_eal/common/Makefile           |   2 +-
> > lib/librte_eal/common/eal_common_uuid.c  | 193 +++++++++++++++++++++++
> > lib/librte_eal/common/include/rte_uuid.h | 129 +++++++++++++++
> > lib/librte_eal/common/meson.build        |   2 +
> > lib/librte_eal/linuxapp/eal/Makefile     |   1 +
> > lib/librte_eal/rte_eal_version.map       |   9 ++
> > 7 files changed, 336 insertions(+), 1 deletion(-)
> > create mode 100644 lib/librte_eal/common/eal_common_uuid.c
> > create mode 100644 lib/librte_eal/common/include/rte_uuid.h
> >   
> 
> Hi Stephen, Why does this need to be in EAl/Common would this be better in the lib directory for utils or string routines? Does the EAl use the feature for something?
> 
> Regards,
> Keith
> 

It could be anywhere. Not tied to being in EAL common but that is where the PCI parsing code is.
Still not 100% sure we need our own version of this simple code. It is more about BSD and eventually Windows support.