From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH 1/7] net/mlx5: rename confusing object in
 probe code
Date: Tue, 12 Jun 2018 15:19:46 +0200
Message-ID: <20180612131946.GU4025@6wind.com>
References: <20180525161814.13873-1-adrien.mazarguil@6wind.com>
 <20180525161814.13873-2-adrien.mazarguil@6wind.com>
 <VI1PR05MB1678AEEB0EB27A055FEF5233AC790@VI1PR05MB1678.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com
 [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 1E7731DE38
 for <dev@dpdk.org>; Tue, 12 Jun 2018 15:20:03 +0200 (CEST)
Received: by mail-wr0-f177.google.com with SMTP id l41-v6so24061553wre.7
 for <dev@dpdk.org>; Tue, 12 Jun 2018 06:20:03 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <VI1PR05MB1678AEEB0EB27A055FEF5233AC790@VI1PR05MB1678.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Jun 10, 2018 at 11:00:57AM +0000, Xueming(Steven) Li wrote:
> Ack except one minor question below.
<snip>
> > -	mlx5_glue->dv_query_device(attr_ctx, &attrs_out);
> > -	if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) {
> > -		if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW) {
> > +	mlx5_glue->dv_query_device(ctx, &dv_attr);
> 
> Should ctx be attr_ctx?.

Indeed, seems like I didn't validate this patch on its own after splitting
it from another. Will fix in v2, thanks.

-- 
Adrien Mazarguil
6WIND