From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 2/7] net/mlx5: remove redundant objects in probe code Date: Tue, 12 Jun 2018 15:19:53 +0200 Message-ID: <20180612131953.GV4025@6wind.com> References: <20180525161814.13873-1-adrien.mazarguil@6wind.com> <20180525161814.13873-3-adrien.mazarguil@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Shahaf Shuler , "dev@dpdk.org" To: "Xueming(Steven) Li" Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 2052A1DEFE for ; Tue, 12 Jun 2018 15:20:10 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id e16-v6so20525152wmd.0 for ; Tue, 12 Jun 2018 06:20:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jun 10, 2018 at 11:00:59AM +0000, Xueming(Steven) Li wrote: > Ack. Trivial issue related to other patch found , not sure whether it good to fix it here. > > - config.tso = ((device_attr_ex.tso_caps.max_tso > 0) && > > - (device_attr_ex.tso_caps.supported_qpts & > > + config.tso = (attr.tso_caps.max_tso > 0 && > > + (attr.tso_caps.supported_qpts & > > (1 << IBV_QPT_RAW_PACKET))); > > Not related to this patch, wrong indent. No problem, I'll add an extra space for v2. -- Adrien Mazarguil 6WIND