From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH 3/7] net/virtio-user: add mgr_rxbuf and
 in_order vdev parameters
Date: Wed, 13 Jun 2018 14:37:23 +0800
Message-ID: <20180613063723.GA27860@debian>
References: <20180608090724.20855-1-yong.liu@intel.com>
 <20180608090724.20855-4-yong.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
To: Marvin Liu <yong.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id DA55D1EE53
 for <dev@dpdk.org>; Wed, 13 Jun 2018 08:37:19 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180608090724.20855-4-yong.liu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 08, 2018 at 05:07:20PM +0800, Marvin Liu wrote:
[...]
> @@ -419,6 +420,12 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
>  		dev->device_features = VIRTIO_USER_SUPPORTED_FEATURES;
>  	}
>  
> +	if (!mrg_rxbuf)
> +		dev->device_features &= ~(1ull << VIRTIO_NET_F_MRG_RXBUF);
> +
> +	if (!in_order)
> +		dev->device_features &= ~(1ull << VIRTIO_F_IN_ORDER);

You also need to handle the server mode case.
In virtio_user_server_reconnect(),
dev->device_features will be overwritten.

Thanks