From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v6 7/7] devtools: expand meson cross compiling coverage Date: Thu, 14 Jun 2018 11:45:04 +0100 Message-ID: <20180614104504.GE17264@bricha3-MOBL.ger.corp.intel.com> References: <1527590616-28299-1-git-send-email-gavin.hu@arm.com> <20180614095127.16245-1-gavin.hu@arm.com> <20180614095127.16245-8-gavin.hu@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, stable@dpdk.org To: Gavin Hu Return-path: Content-Disposition: inline In-Reply-To: <20180614095127.16245-8-gavin.hu@arm.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 14, 2018 at 05:51:27PM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to cover both, gcc and clang. And also the build dirs are > changed to *-host-$c, indicating the difference of cc used. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Phil Yang > Reviewed-by: Song Zhu > --- Given that the only native code we have in a cross-build is pmdinfogen, doing two copies of each cross-build seems overkill, and makes the test longer than it should be. I suggest that we just do one of the cross-builds, e.g. the generic armv8 one, for both clang and gcc, and do the others only once. /Bruce