From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v11 4/6] devtools: fix the missing ninja
 command error
Date: Tue, 19 Jun 2018 13:30:09 +0100
Message-ID: <20180619123009.GA20032@bricha3-MOBL.ger.corp.intel.com>
References: <20180615102143.12778-1-gavin.hu@arm.com>
 <20180619013746.13268-1-gavin.hu@arm.com>
 <20180619013746.13268-5-gavin.hu@arm.com>
 <20180619101220.GB23348@bricha3-MOBL.ger.corp.intel.com>
 <VI1PR08MB31677459DC6C5CC3D58C66228F700@VI1PR08MB3167.eurprd08.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: Gavin Hu <Gavin.Hu@arm.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <VI1PR08MB31677459DC6C5CC3D58C66228F700@VI1PR08MB3167.eurprd08.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 19, 2018 at 10:41:06AM +0000, Gavin Hu wrote:
> Hi Bruce,
> 
> Thanks for your review, I submitted v12 patch to address all your new comments.
> 
> BTW, do you know why pwclient can NOT work successfully today? 
> It worked fine at my side previously, any changes at the server side? The error is below: 
> xmlrpc.client.ProtocolError: <ProtocolError for dpdk.org/dev/patchwork/xmlrpc/: 301 Moved Permanently>
> 
> Best Regards,
> Gavin

Paths on the server have changed, so you need to update your .pwclientrc
file to point to the new path. Patchwork is now at "patches.dpdk.org"
> 
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Tuesday, June 19, 2018 6:12 PM
> > To: Gavin Hu <Gavin.Hu@arm.com>
> > Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v11 4/6] devtools: fix the missing ninja
> > command error
> > 
> > On Tue, Jun 19, 2018 at 09:37:44AM +0800, Gavin Hu wrote:
> > > On some linux distributions, eg: CentOS, the ninja executable has a
> > > different name: ninja-build, this patch is to check and adapt to it
> > > accordingly.
> > >
> > > ./devtools/test-meson-builds.sh: line 24: ninja: command not found
> > >
> > > Fixes: a55277a788 ("devtools: add test script for meson builds")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > > Reviewed-by: Song Zhu <song.zhu@arm.com>
> > > ---
> > This is previously acked.