From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajit Khaparde Subject: [PATCH 10/31] net/bnxt: code cleanup style of bnxt cpr Date: Tue, 19 Jun 2018 14:30:37 -0700 Message-ID: <20180619213058.12273-11-ajit.khaparde@broadcom.com> References: <20180619213058.12273-1-ajit.khaparde@broadcom.com> Cc: ferruh.yigit@intel.com, Scott Branden To: dev@dpdk.org Return-path: Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id E34481B053 for ; Tue, 19 Jun 2018 23:31:08 +0200 (CEST) In-Reply-To: <20180619213058.12273-1-ajit.khaparde@broadcom.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Scott Branden Cleanup alignment, brackets, debug string style of bnxt_cpr Signed-off-by: Scott Branden Reviewed-by: Ajit Khaparde Reviewed-by: Qingmin Liu Reviewed-by: Ray Jui --- drivers/net/bnxt/bnxt_cpr.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c index ff20b6fdf..7257bbedc 100644 --- a/drivers/net/bnxt/bnxt_cpr.c +++ b/drivers/net/bnxt/bnxt_cpr.c @@ -74,12 +74,12 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) fwd_cmd = (struct input *)bp->pf.vf_info[vf_id].req_buf; if (fw_vf_id < bp->pf.first_vf_id || - fw_vf_id >= (bp->pf.first_vf_id) + bp->pf.active_vfs) { + fw_vf_id >= bp->pf.first_vf_id + bp->pf.active_vfs) { PMD_DRV_LOG(ERR, - "FWD req's source_id 0x%x out of range 0x%x - 0x%x (%d %d)\n", - fw_vf_id, bp->pf.first_vf_id, - (bp->pf.first_vf_id) + bp->pf.active_vfs - 1, - bp->pf.first_vf_id, bp->pf.active_vfs); + "FWD req 0x%x out of range 0x%x - 0x%x (%d %d)\n", + fw_vf_id, bp->pf.first_vf_id, + bp->pf.first_vf_id + bp->pf.active_vfs - 1, + bp->pf.first_vf_id, bp->pf.active_vfs); goto reject; } @@ -95,7 +95,7 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) if (vfc->enables & HWRM_FUNC_VF_CFG_INPUT_ENABLES_DFLT_MAC_ADDR) { bnxt_hwrm_func_vf_mac(bp, vf_id, - (const uint8_t *)"\x00\x00\x00\x00\x00"); + (const uint8_t *)"\x00\x00\x00\x00\x00"); } } if (fwd_cmd->req_type == HWRM_CFA_L2_SET_RX_MASK) { @@ -104,10 +104,10 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) srm->vlan_tag_tbl_addr = rte_cpu_to_le_64(0); srm->num_vlan_tags = rte_cpu_to_le_32(0); - srm->mask &= ~rte_cpu_to_le_32( - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLANONLY | - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN | - HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN); + srm->mask &= ~rte_cpu_to_le_32 + (HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLANONLY | + HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN | + HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN); } /* Forward */ rc = bnxt_hwrm_exec_fwd_resp(bp, fw_vf_id, fwd_cmd, req_len); @@ -128,8 +128,6 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl) fw_vf_id - bp->pf.first_vf_id, rte_le_to_cpu_16(fwd_cmd->req_type)); } - - return; } int bnxt_event_hwrm_resp_handler(struct bnxt *bp, struct cmpl_base *cmp) -- 2.15.1 (Apple Git-101)