From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] usertools: fix build with gcc
Date: Thu, 21 Jun 2018 10:55:02 +0100
Message-ID: <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com>
References: <1529573741-9606-1-git-send-email-choonho.son@gmail.com>
 <1529573741-9606-2-git-send-email-choonho.son@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Choonho Son <choonho.son@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 280031BB92
 for <dev@dpdk.org>; Thu, 21 Jun 2018 11:55:08 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1529573741-9606-2-git-send-email-choonho.son@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jun 21, 2018 at 09:35:41AM +0000, Choonho Son wrote:
> dpdk-setup.sh fails to build with lack of environment variable
> 
> Build complete [x86_64-native-linuxapp-gcc]
> Installation cannot run with T defined and DESTDIR undefined
> 
> Signed-off-by: Choonho Son <choonho.son@gmail.com>
> ---
>  usertools/dpdk-setup.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
> index 5eebbce..5248e7a 100755
> --- a/usertools/dpdk-setup.sh
> +++ b/usertools/dpdk-setup.sh
> @@ -65,6 +65,7 @@ setup_target()
>  {
>  	option=$1
>  	export RTE_TARGET=${TARGETS[option]}
> +	export DESTDIR=${DESTDIR:-install}
>  
>  	compiler=${RTE_TARGET##*-}
>  	if [ "$compiler" == "icc" ] ; then
> @@ -76,7 +77,7 @@ setup_target()
>  		fi
>  	fi
>  	if [ "$QUIT" == "0" ] ; then
> -		make install T=${RTE_TARGET}
> +		make install T=${RTE_TARGET} DESTDIR=${DESTDIR}
>  	fi
>  	echo "------------------------------------------------------------------------------"
>  	echo " RTE_TARGET exported as $RTE_TARGET"

The message about no DESTDIR is not really an error, the build has
completed successfully. I don't think copying the build over to a new
directory is something we should always do as part of this script.

/Bruce