From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create() Date: Mon, 25 Jun 2018 16:40:47 +0200 Message-ID: <20180625144047.ktlcpstkfcmyhxcl@platinum> References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> <1528461427-164113-2-git-send-email-dariuszx.stojaczyk@intel.com> <387954ec-779e-6f29-5966-f8d2a41945e1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dariusz Stojaczyk , dev@dpdk.org, stable@dpdk.org To: "Burakov, Anatoly" Return-path: Content-Disposition: inline In-Reply-To: <387954ec-779e-6f29-5966-f8d2a41945e1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 18, 2018 at 11:01:40AM +0100, Burakov, Anatoly wrote: > On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote: > > This function returned positive error numbers instead > > of negative ones as desbribed in the doc. What's worse, > > multiple of its callers only check for (rc < 0) to detect > > failure. > > > > It was incorrectly assumed that pthread_create > > and pthread_setaffinity_np return negative errnos. They > > always returns positive ones, so this patch negates their > > return values before returning. > > > > Fixes: 9e5afc72c909 ("eal: add function to create control threads") > > Cc: olivier.matz@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Dariusz Stojaczyk > > --- > > Acked-by: Anatoly Burakov Reviewed-by: Olivier Matz Thanks for the fix.