From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: Re: [PATCH v2] eal/devargs: add option to supply PCI dev
 args
Date: Wed, 27 Jun 2018 14:25:30 +0530
Message-ID: <20180627085529.GA14236@ltp-pvn>
References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com>
 <DB7PR05MB44263B4166F9091A0719B7B3C3490@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <cd4dd9fe-d5d5-ebbf-0738-bb3dfcbd2da9@intel.com>
 <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>,
 Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0042.outbound.protection.outlook.com [104.47.41.42])
 by dpdk.org (Postfix) with ESMTP id 05FA01BED9
 for <dev@dpdk.org>; Wed, 27 Jun 2018 11:06:24 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Gaëtan,

On Wed, Jun 27, 2018 at 10:39:59AM +0200, Gaëtan Rivet wrote:
> Hi Ferruh, Pavan,
>
> sorry for the delay,
>
> On Tue, Jun 26, 2018 at 04:40:21PM +0100, Ferruh Yigit wrote:
> > On 6/26/2018 1:48 PM, Shahaf Shuler wrote:
> > > Hi Pavan,
> > >
> > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh:
> > >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev
> > >> args
> > >>
> > >> Currently, the only way of supplying device argument to a pci device is to
> > >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method
> > >> as whitelisting a device has its own side effects i.e only the whitelisted pci
> > >> devices are probed.
> > >>
> > >> Add a new eal command line option --pci-args to pass device args without the
> > >> need to whitelist the devices.
> > >>            --pci-args 000X:00:0X.0,self_test=1
> > >>
> > >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > >
> > > Tested-by: Shahaf Shuler <shahafs@mellanox.com>
> > >
> > > It seems to work.
> > > Please see small comments below
> >
> > Isn't this conflict with Gaetan's devarg work which has wider scope?
> >
>
> Indeed it does.
>
> Pavan, I have submitted a new version of a series adding generic kvargs
> to several layers (bus, class, driver).
>
> It does cover this exact use-case.
>
> However, while writing it, I wasn't able to find PCI bus specific
> parameters, that could showcase the functionality.

The idea of the patch is to avoid whitelising a device when we want to
supply kvargs to it, I tried mapping it to devargs rework patchset but couldn't
do it at a glance. For example, the following patch[1] reads kvargs through
whitelisting which should be avoided.

[1]http://patches.dpdk.org/patch/41223/

>
> It would help the development if you could provide which parameter you
> wanted to implement, I could add it in my own series, which would
> streamline all of this.

+1

>
> Regards,
> --
> Gaëtan Rivet
> 6WIND

Thanks,
Pavan.