From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v2 5/7] net/mlx5: add port representor
 awareness
Date: Wed, 27 Jun 2018 15:32:03 +0200
Message-ID: <20180627133202.GT4025@6wind.com>
References: <20180525161814.13873-1-adrien.mazarguil@6wind.com>
 <20180614083047.10812-1-adrien.mazarguil@6wind.com>
 <20180614083047.10812-6-adrien.mazarguil@6wind.com>
 <AM5PR0501MB24206A03C4D206AF8DACF521AC730@AM5PR0501MB2420.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 340661BB72
 for <dev@dpdk.org>; Wed, 27 Jun 2018 15:32:20 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id e18-v6so2079320wrs.5
 for <dev@dpdk.org>; Wed, 27 Jun 2018 06:32:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <AM5PR0501MB24206A03C4D206AF8DACF521AC730@AM5PR0501MB2420.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, Jun 16, 2018 at 08:37:14AM +0000, Xueming(Steven) Li wrote:
> Reviewed-by: Xueming Li <xuemingl@mellanox.com>
> 
> One minor issue we should be able to ignore.
<snip>
> > +static int
> > +mlx5_cmp_ibv_name(const void *a, const void *b) {
> > +	const char *name_a = (*(const struct ibv_device *const *)a)->name;
> > +	const char *name_b = (*(const struct ibv_device *const *)b)->name;
> > +	size_t i = 0;
> > +
> > +	while (name_a[i] && name_a[i] == name_b[i])
> > +		++i;
> > +	while (i && isdigit(name_a[i - 1]) && isdigit(name_b[i - 1]))
> 
> name_a[i - 1] and name_b[i - 1] must be same here.

Indeed, I'll simplify it in v3, thanks.

-- 
Adrien Mazarguil
6WIND