From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Gora Subject: [PATCH 1/1] kni: fix segfault in rte_kni_get Date: Thu, 28 Jun 2018 15:58:38 -0700 Message-ID: <20180628225838.22732-1-dg@adax.com> Cc: dev@dpdk.org, Dan Gora , marc.sune@bisdn.de To: Ferruh Yigit Return-path: Received: from mail-ot0-f195.google.com (mail-ot0-f195.google.com [74.125.82.195]) by dpdk.org (Postfix) with ESMTP id D77B31B43B for ; Fri, 29 Jun 2018 00:58:57 +0200 (CEST) Received: by mail-ot0-f195.google.com with SMTP id h6-v6so7982118otj.0 for ; Thu, 28 Jun 2018 15:58:57 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix a segmentation fault which occurs when the kni_autotest is run in the 'test' application. This segmenation fault occurs when rte_kni_get() is called with a NULL value for 'name'. Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") Cc: marc.sune@bisdn.de Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c index aa3559306..c4199e6ab 100644 --- a/lib/librte_kni/rte_kni.c +++ b/lib/librte_kni/rte_kni.c @@ -744,6 +744,9 @@ rte_kni_get(const char *name) struct rte_kni_memzone_slot *it; struct rte_kni *kni; + if (name == NULL || name[0] == '\0') + return NULL; + /* Note: could be improved perf-wise if necessary */ for (i = 0; i < kni_memzone_pool.max_ifaces; i++) { it = &kni_memzone_pool.slots[i]; -- 2.18.0.rc1.1.g6f333ff2f