From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v3 1/7] vhost: use shadow used ring in
	dequeue path
Date: Tue, 3 Jul 2018 11:28:19 +0800
Message-ID: <20180703032819.GA3041@debian>
References: <20180627144959.17277-1-maxime.coquelin@redhat.com>
 <20180627144959.17277-2-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: zhihong.wang@intel.com, dev@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 9B1C61BE31
 for <dev@dpdk.org>; Tue,  3 Jul 2018 05:28:21 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180627144959.17277-2-maxime.coquelin@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 27, 2018 at 04:49:53PM +0200, Maxime Coquelin wrote:
[...]
> @@ -1164,8 +1136,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
>  
>  			if (mbuf_is_consumed(zmbuf->mbuf)) {
>  				used_idx = vq->last_used_idx++ & (vq->size - 1);

Above line and other `used_idx` related code in
this function should be removed too.

Apart from that,
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks!

> -				update_used_ring(dev, vq, used_idx,
> -						 zmbuf->desc_idx);
> +				update_shadow_used_ring(vq, zmbuf->desc_idx, 0);
>  				nr_updated += 1;
>  
>  				TAILQ_REMOVE(&vq->zmbuf_list, zmbuf, next);
[...]