From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 6/7] examples/kni: fix dependency check for
 building with meson
Date: Tue, 3 Jul 2018 11:07:46 +0100
Message-ID: <20180703100745.GA1296@bricha3-MOBL.ger.corp.intel.com>
References: <20180608163807.66737-1-bruce.richardson@intel.com>
 <20180608163807.66737-7-bruce.richardson@intel.com>
 <25eed419-0786-d92d-9aa5-7d8bf7c0c349@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id A24B31BEE3
 for <dev@dpdk.org>; Tue,  3 Jul 2018 12:07:50 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <25eed419-0786-d92d-9aa5-7d8bf7c0c349@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 03, 2018 at 12:47:18AM +0100, Ferruh Yigit wrote:
> On 6/8/2018 5:38 PM, Bruce Richardson wrote:
> > Rather than hard-coding the example app to be built only when a set of
> > conditions are met, we can simplify things by having the app built when
> > KNI library itself is available. That saves us duplicating the same set
> > of restrictions on both library and example app.
> > 
> > Fixes: 89f0711f9ddf ("examples: build some samples with meson")
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  examples/kni/meson.build | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/examples/kni/meson.build b/examples/kni/meson.build
> > index 0443ab99b..41b87f8b3 100644
> > --- a/examples/kni/meson.build
> > +++ b/examples/kni/meson.build
> > @@ -6,9 +6,8 @@
> >  # To build this example as a standalone application with an already-installed
> >  # DPDK instance, use 'make'
> >  
> > -if host_machine.system() != 'linux'
> > -	build = false
> > -endif
> > +# this app can be built if-and-only-if KNI library is buildable
> > +build = dpdk_conf.has('LIB_LIBRTE_KNI')
> 
> s/LIB_LIBRTE_KNI/RTE_LIBRTE_KNI/
> 
> Same needs to be updated in drivers/net/kni/meson.build too
> 
Thanks, good catch.