From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marvin Liu Subject: [PATCH] net/virtio: fix build with gcc optimization on Date: Wed, 4 Jul 2018 18:56:25 +0800 Message-ID: <20180704105625.39462-1-yong.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, tiwei.bie@intel.com, Marvin Liu To: maxime.coquelin@redhat.com, ferruh.yigit@intel.com Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A3D6B1BE8E for ; Wed, 4 Jul 2018 05:10:56 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" build error on gcc version 8.1.1 20180502 (Red Hat 8.1.1-1), with optimization level >= O2 .../drivers/net/virtio/virtio_rxtx.c: In function ‘virtio_xmit_cleanup_inorder’: .../drivers/net/virtio/virtio_rxtx.c:195:24: error: ‘desc_idx’ may be used uninitialized in this function [-Werror=maybe-uninitialized] uint16_t i, used_idx, desc_idx, last_idx; ^~~~~~~~ Optimization option fcode-hoisting will cause error on gcc 8.x.x. Initialize desc_idx before using can fix build error. Fixes: e3851816e63c ("net/virtio: support in-order Rx and Tx") Reported-by: Ferruh Yigit Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 6394071b8..19beb4bf4 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -192,7 +192,8 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t num) static void virtio_xmit_cleanup_inorder(struct virtqueue *vq, uint16_t num) { - uint16_t i, used_idx, desc_idx, last_idx; + uint16_t i, used_idx, last_idx; + uint16_t desc_idx = 0; int16_t free_cnt = 0; struct vq_desc_extra *dxp = NULL; -- 2.17.0