From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v7 09/15] vhost: add shadow used ring support
 for packed rings
Date: Thu, 5 Jul 2018 22:03:51 +0800
Message-ID: <20180705140351.GA28449@debian>
References: <20180704215438.5579-1-maxime.coquelin@redhat.com>
 <20180704215438.5579-10-maxime.coquelin@redhat.com>
 <20180705071508.GA21112@debian>
 <7b2e9f2f-cefd-c4d5-2995-28f3353e49b4@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
 mst@redhat.com, jasowang@redhat.com, wexu@redhat.com
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 5DD2D1BE32
 for <dev@dpdk.org>; Thu,  5 Jul 2018 16:04:13 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <7b2e9f2f-cefd-c4d5-2995-28f3353e49b4@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 05, 2018 at 02:49:34PM +0200, Maxime Coquelin wrote:
> On 07/05/2018 09:15 AM, Tiwei Bie wrote:
> > On Wed, Jul 04, 2018 at 11:54:32PM +0200, Maxime Coquelin wrote:
> > [...]
> > > +
> > > +static __rte_always_inline void
> > > +flush_shadow_used_ring_packed(struct virtio_net *dev,
> > > +			struct vhost_virtqueue *vq)
> > > +{
> > [...]
> > > +}
> > > +
> > > +static __rte_always_inline void
> > > +update_shadow_used_ring_packed(struct vhost_virtqueue *vq,
> > > +			 uint16_t desc_idx, uint16_t len, uint16_t count)
> > > +{
> > > +	uint16_t i = vq->shadow_used_idx++;
> > > +
> > > +	vq->shadow_used_packed[i].id  = desc_idx;
> > > +	vq->shadow_used_packed[i].len = len;
> > > +	vq->shadow_used_packed[i].count = count;
> > >   }
> > 
> > I met below build errors in this patch when doing
> > per-patch build test with clang:
> > 
> > lib/librte_vhost/virtio_net.c:134:1: error: unused function 'flush_shadow_used_ring_packed'
> >        [-Werror,-Wunused-function]
> > flush_shadow_used_ring_packed(struct virtio_net *dev,
> > ^
> > lib/librte_vhost/virtio_net.c:188:1: error: unused function 'update_shadow_used_ring_packed'
> >        [-Werror,-Wunused-function]
> > update_shadow_used_ring_packed(struct vhost_virtqueue *vq,
> > ^
> > 
> > It's better to add __rte_unused in this patch,
> > and remove it when functions are used.
> > 
> > PS. I also saw similar errors with fill_vec_buf_packed()
> >      in patch 11/15.
> > 
> 
> Thanks for the report, I missed these build issues...
> This is not fixed using __rte_unused as you suggested.
> 

Why not? This can be fixed by something like this
on my machine:

-static __rte_always_inline void
+static __rte_always_inline __rte_unused void
 flush_shadow_used_ring_packed(struct virtio_net *dev,
 			struct vhost_virtqueue *vq)
 {

And __rte_unused can be removed in the patch that
above function is called.

Best regards,
Tiwei Bie