From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH v9 03/15] vhost: vring address setup for
	packed queues
Date: Mon, 9 Jul 2018 10:09:32 +0800
Message-ID: <20180709020932.GA16302@debian>
References: <20180706070722.2043-1-maxime.coquelin@redhat.com>
 <20180706070722.2043-4-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org,
 mst@redhat.com, jasowang@redhat.com, wexu@redhat.com,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Jens Freimann <jfreiman@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id CBFA37EDC
 for <dev@dpdk.org>; Mon,  9 Jul 2018 04:09:50 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180706070722.2043-4-maxime.coquelin@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 06, 2018 at 09:07:10AM +0200, Maxime Coquelin wrote:
[...]
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index bea6a0428..dca43ff00 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -467,6 +467,27 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)
>  	struct vhost_vring_addr *addr = &vq->ring_addrs;
>  	uint64_t len;
>  
> +	if (vq_is_packed(dev)) {
> +		len = sizeof(struct vring_packed_desc) * vq->size;
> +		vq->desc_packed = (struct vring_packed_desc *) ring_addr_to_vva

FYI, above code will cause below build error on 32bit platform:

/tmp/dpdk-build/lib/librte_vhost/vhost_user.c: In function ‘translate_ring_addresses’:
/tmp/dpdk-build/lib/librte_vhost/vhost_user.c:472:21: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
   vq->desc_packed = (struct vring_packed_desc *) ring_addr_to_vva
                     ^

I'll fix it while applying.