From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [PATCH] net/enic: pick the right Rx handler after
	changing MTU
Date: Sat, 14 Jul 2018 14:12:09 +0900
Message-ID: <20180714051207.GA10152@HYONKIM-7R0DR.cisco.com>
References: <20180714005452.28195-1-johndale@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: ferruh.yigit@intel.com, dev@dpdk.org
To: John Daley <johndale@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73])
 by dpdk.org (Postfix) with ESMTP id 89872DE3
 for <dev@dpdk.org>; Sat, 14 Jul 2018 07:12:14 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180714005452.28195-1-johndale@cisco.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

Please ignore this patch, as it never assigns the default handler to
rx_pkt_burst. We will send a v2. Sorry about that.

On Fri, Jul 13, 2018 at 05:54:52PM -0700, John Daley wrote:
> From: Hyong Youb Kim <hyonkim@cisco.com>
> 
> enic_set_mtu always reverts to the default Rx handler after changing
> MTU. Try to use the simpler, non-scatter handler in this case as well.
[...]
> +	/* Use the non-scatter, simplified RX handler if possible. */
> +	if (enic->rq_count > 0 && enic->rq[0].data_queue_enable == 0) {
> +		PMD_INIT_LOG(DEBUG, " use the non-scatter Rx handler");
> +		eth_dev = enic->rte_dev;
> +		eth_dev->rx_pkt_burst = &enic_noscatter_recv_pkts;
> +	} else {
> +		PMD_INIT_LOG(DEBUG, " use the normal Rx handler");

Here, we should set rx_pkt_burst = enic_recv_pkts

-Hyong