From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v2 1/2] ring: fix declaration after code
Date: Mon, 16 Jul 2018 09:15:30 +0200
Message-ID: <20180716071530.5gelmvk3htows3uj@platinum>
References: <152749815575.44120.3090426090234773551.stgit@localhost.localdomain>
 <152749821848.44120.9534717185541492433.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id CB82A201
 for <dev@dpdk.org>; Mon, 16 Jul 2018 09:15:33 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <152749821848.44120.9534717185541492433.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 28, 2018 at 05:03:38PM +0800, Andy Green wrote:
> On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:
> 
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h: In function
> '__rte_ring_move_prod_head':
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h:69:3: warning: ISO C90
> forbids mixed declarations and code
> [-Wdeclaration-after-statement]
>    const uint32_t cons_tail = r->cons.tail;
>    ^
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h: In function
> '__rte_ring_move_cons_head':
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h:136:3: warning: ISO C90
> forbids mixed declarations and code
> [-Wdeclaration-after-statement]
>    const uint32_t prod_tail = r->prod.tail;
>    ^
> 
> Signed-off-by: Andy Green <andy@warmcat.com>
> Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")

Acked-by: Olivier Matz <olivier.matz@6wind.com>