From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: [PATCH] examples/exception_path: fix possible out-of-bounds read Date: Mon, 16 Jul 2018 17:03:47 +0100 Message-ID: <20180716160347.35376-1-bruce.richardson@intel.com> Cc: Bruce Richardson , stable@dpdk.org To: dev@dpdk.org Return-path: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When printing out stats from the exception_path app, all possible lcore_ids are iterated. However, the app only supports up to 64 cores. To prevent possible errors, and to remove coverity warnings, explicitly check for out-of-range lcore ids before printing. Coverity issue: 268335 Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- examples/exception_path/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c index 0b59f6b3f..440422bc8 100644 --- a/examples/exception_path/main.c +++ b/examples/exception_path/main.c @@ -131,6 +131,9 @@ print_stats(void) " Lcore Port RX TX Dropped on TX\n" "------- ------ ------------ ------------ ---------------\n"); RTE_LCORE_FOREACH(i) { + /* limit ourselves to application supported cores only */ + if (i >= APP_MAX_LCORE) + break; printf("%6u %7u %13"PRIu64" %13"PRIu64" %16"PRIu64"\n", i, (unsigned)port_ids[i], lcore_stats[i].rx, lcore_stats[i].tx, -- 2.17.1