From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH 1/4] eal: fix hotplug add and hotplug remove Date: Wed, 18 Jul 2018 15:10:26 +0200 Message-ID: <20180718131026.3qfymf45meglfuea@bidouze.vm.6wind.com> References: <20180712140144.18146-1-qi.z.zhang@intel.com> <20180712140144.18146-2-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org, stable@dpdk.org To: Qi Zhang Return-path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id C08671C01 for ; Wed, 18 Jul 2018 15:10:44 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id r16-v6so4624441wrt.11 for ; Wed, 18 Jul 2018 06:10:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180712140144.18146-2-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, On Thu, Jul 12, 2018 at 10:01:41PM +0800, Qi Zhang wrote: > If hotplug add an already plugged PCI device, it will > cause rte_pci_device->device.name be corrupted due to unexpected > rte_devargs_remove. Also if try to hotplug remove an already > unplugged device, it will cause segment fault due to unexpected > bus->unplug on a rte_device whose driver is NULL. > The patch fix these issues. > > Fixes: 7e8b26650146 ("eal: fix hotplug add / remove") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang I think we should consolidate this API at some point, maybe list the possible error values as a part of it and remove the experimental tag. In any case, the fix seems correct, thanks, Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND