From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] drivers/net: fix segfault in secondary
 process
Date: Thu, 19 Jul 2018 09:32:00 -0700
Message-ID: <20180719093200.6095b52c@xeon-e3>
References: <20180719164556.93162-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "John W. Linville" <linville@tuxdriver.com>, Declan Doherty
 <declan.doherty@intel.com>, Chas Williams <chas3@att.com>, Gaetan Rivet
 <gaetan.rivet@6wind.com>, Tetsuya Mukawa <mtetsuyah@gmail.com>, Santosh
 Shukla <santosh.shukla@caviumnetworks.com>, Jerin Jacob
 <jerin.jacob@caviumnetworks.com>, Keith Wiles <keith.wiles@intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie
 <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, dev@dpdk.org,
 stable@dpdk.org, Vipin Varghese <vipin.varghese@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 534C2548B
 for <dev@dpdk.org>; Thu, 19 Jul 2018 18:32:04 +0200 (CEST)
Received: by mail-pg1-f194.google.com with SMTP id x5-v6so4225266pgp.7
 for <dev@dpdk.org>; Thu, 19 Jul 2018 09:32:04 -0700 (PDT)
In-Reply-To: <20180719164556.93162-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 19 Jul 2018 17:45:56 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> Calling rte_eth_dev_info_get() on secondary process cause a crash
> because eth_dev->device is not set properly.
> 
> Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Good catch.

Maybe eth_dev should do this for the device drivers?
Better to make device drivers as simple and safe as possible.

There seem to be a lot of bugs related to secondary process model.
Do we have a test suite for that.