From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH] devtools: fix checkpatch for filename with space Date: Fri, 20 Jul 2018 13:41:03 +0200 Message-ID: <20180720114103.18211-1-thomas@monjalon.net> Cc: dev@dpdk.org To: nhorman@tuxdriver.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 529C329AC for ; Fri, 20 Jul 2018 13:41:12 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If the patch filename or the temporary file path have a space in their name, the script checkpatches.sh does not work. The variables for the filenames must be enclosed in quotes in order to preserve spaces. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Signed-off-by: Thomas Monjalon --- Strangely, I did a fix for check-symbol-change.sh and I forgot to fix checkpatches.sh. --- devtools/checkpatches.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 1439bce94..e97a4f2c9 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -25,7 +25,7 @@ NEW_TYPEDEFS,COMPARISON_TO_NULL" clean_tmp_files() { if echo $tmpinput | grep -q '^checkpatches\.' ; then - rm -f $tmpinput + rm -f "$tmpinput" fi } @@ -77,13 +77,13 @@ check () { # elif [ -n "$2" ] ; then tmpinput=$(mktemp checkpatches.XXXXXX) git format-patch --find-renames \ - --no-stat --stdout -1 $commit > $tmpinput + --no-stat --stdout -1 $commit > "$tmpinput" else tmpinput=$(mktemp checkpatches.XXXXXX) - cat > $tmpinput + cat > "$tmpinput" fi - report=$($DPDK_CHECKPATCH_PATH $options $tmpinput 2>/dev/null) + report=$($DPDK_CHECKPATCH_PATH $options "$tmpinput" 2>/dev/null) if [ $? -ne 0 ] ; then $verbose || printf '\n### %s\n\n' "$3" printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p' -- 2.17.1