From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v5 1/3] crypto/openssl: add rsa and mod asym
 op
Date: Mon, 23 Jul 2018 09:50:27 -0700
Message-ID: <20180723095027.40c7c1bf@xeon-e3>
References: <1532357165-8575-1-git-send-email-shally.verma@caviumnetworks.com>
 <1532357165-8575-2-git-send-email-shally.verma@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org,
 pathreya@caviumnetworks.com, nmurthy@caviumnetworks.com, Sunila Sahu
 <sunila.sahu@caviumnetworks.com>, Ashish Gupta
 <ashish.gupta@caviumnetworks.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com
 [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id A5A91F72
 for <dev@dpdk.org>; Mon, 23 Jul 2018 18:50:31 +0200 (CEST)
Received: by mail-pf1-f195.google.com with SMTP id k19-v6so206953pfi.1
 for <dev@dpdk.org>; Mon, 23 Jul 2018 09:50:31 -0700 (PDT)
In-Reply-To: <1532357165-8575-2-git-send-email-shally.verma@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 23 Jul 2018 20:16:03 +0530
Shally Verma <shally.verma@caviumnetworks.com> wrote:

> +#define set_rsa_params(rsa, p, q, ret) \
> +	do {rsa->p = p; rsa->q = q; ret = 0; } while (0)
> +
> +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
> +	do { \
> +		rsa->dmp1 = dmp1; \
> +		rsa->dmq1 = dmq1; \
> +		rsa->iqmp = iqmp; \
> +		ret = 0; \
> +	} while (0)
> +
> +#define set_rsa_keys(rsa, n, e, d, ret) \
> +	do { \
> +		rsa->n = n; rsa->e = e; rsa->d = d; ret = 0; \
> +	} while (0)
> +
> +#else
> +
> +#define set_rsa_params(rsa, p, q, ret) \
> +	(ret = !RSA_set0_factors(rsa, p, q))
> +
> +#define set_rsa_crt_params(rsa, dmp1, dmq1, iqmp, ret) \
> +	(ret = !RSA_set0_crt_params(rsa, dmp1, dmq1, iqmp))
> +
> +/* n, e must be non-null, d can be NULL */
> +#define set_rsa_keys(rsa, n, e, d, ret) \
> +	(ret = !RSA_set0_key(rsa, n, e, d))
> +
> +#endif /* version < 10100000 */
> +
> +#endif /* __RTA_COMPAT_H__ */

Please use inline functions instead of macros.
The crypto code seems to favor macros?

Macro's have no type checking and are not faster anyway.