From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH] net/octeontx: fix stop clearing fastpath
 functions
Date: Tue, 24 Jul 2018 21:09:04 +0530
Message-ID: <20180724153903.GC11073@jerin>
References: <20180724104350.20652-1-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com, dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0052.outbound.protection.outlook.com [104.47.36.52])
 by dpdk.org (Postfix) with ESMTP id 67FCB98
 for <dev@dpdk.org>; Tue, 24 Jul 2018 17:39:18 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20180724104350.20652-1-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Tue, 24 Jul 2018 16:13:50 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
>  ferruh.yigit@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath
>  functions
> X-Mailer: git-send-email 2.18.0
> 
> On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes
> a SEGFAULT in cases where control path calls stop and a paket is still
> being processed by a worker.
> Instead clear the fastpath functions in dev_close.
> 
> Fixes: da6c687471a3 ("net/octeontx: add start and stop support")

Cc: stable@dpdk.org

> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/net/octeontx/octeontx_ethdev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
> index 1eb453b21..8fe868678 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -352,6 +352,9 @@ octeontx_dev_close(struct rte_eth_dev *dev)
>  
>  		rte_free(txq);
>  	}
> +
> +	dev->tx_pkt_burst = NULL;
> +	dev->rx_pkt_burst = NULL;
>  }
>  
>  static int
> @@ -445,9 +448,6 @@ octeontx_dev_stop(struct rte_eth_dev *dev)
>  			     ret);
>  		return;
>  	}
> -
> -	dev->tx_pkt_burst = NULL;
> -	dev->rx_pkt_burst = NULL;
>  }
>  
>  static void
> -- 
> 2.18.0
>