From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] devtools: check_symbol_change requires bash
Date: Tue, 31 Jul 2018 09:31:45 -0700
Message-ID: <20180731093145.2c257a89@xeon-e3>
References: <20180731151416.4868-1-stephen@networkplumber.org>
 <B27915DBBA3421428155699D51E4CFE23F3C5321@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "dev@dpdk.org"
 <dev@dpdk.org>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id D4F072B92
 for <dev@dpdk.org>; Tue, 31 Jul 2018 18:31:48 +0200 (CEST)
Received: by mail-pf1-f194.google.com with SMTP id j8-v6so6365546pff.6
 for <dev@dpdk.org>; Tue, 31 Jul 2018 09:31:48 -0700 (PDT)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23F3C5321@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 31 Jul 2018 16:01:19 +0000
"Mcnamara, John" <john.mcnamara@intel.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, July 31, 2018 4:14 PM
> > To: nhorman@tuxdriver.com
> > Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>
> > Subject: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash
> > 
> > The syntax of check_symbol_change uses some bash syntax.
> > It does not run correctly on Debian where /bin/sh is not the same as
> > /bin/bash.  
> 
> I think this fix may be required for devtools/checkpatches.sh as well
> since it seems to use bash specific call to trap().
> 
> I saw this in an internal bug report but didn't have a system to check
> the fix on. Could you do a quick check.

Yes, checkpatches also needs to be bashifyed.