From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Daley Subject: [PATCH] net/enic: reset the vxlan port during vNIC initialization Date: Tue, 31 Jul 2018 14:13:12 -0700 Message-ID: <20180731211312.7299-1-johndale@cisco.com> Cc: dev@dpdk.org, Hyong Youb Kim To: ferruh.yigit@intel.com Return-path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 42BBB44C3 for ; Tue, 31 Jul 2018 23:13:17 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Hyong Youb Kim The NIC persists the vxlan port number across vNIC init/de-init (e.g. restart testpmd). So, explicitly reset the setting to the default value (4789) as part of the initialization. Fixes: 8a4efd17410c ("net/enic: add handlers to add/delete vxlan port number") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley johndale@cisco.com> --- drivers/net/enic/enic_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index f04dc0878..03bde76b2 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1664,6 +1664,16 @@ static int enic_dev_init(struct enic *enic) enic->overlay_offload = true; enic->vxlan_port = ENIC_DEFAULT_VXLAN_PORT; dev_info(enic, "Overlay offload is enabled\n"); + /* + * Reset the vxlan port to the default, as the NIC firmware + * does not reset it automatically and keeps the old setting. + */ + if (vnic_dev_overlay_offload_cfg(enic->vdev, + OVERLAY_CFG_VXLAN_PORT_UPDATE, + ENIC_DEFAULT_VXLAN_PORT)) { + dev_err(enic, "failed to update vxlan port\n"); + return -EINVAL; + } } return 0; -- 2.16.2