From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH] net/virtio-user: fix the param string
Date: Wed, 1 Aug 2018 10:06:35 +0800
Message-ID: <20180801020635.GA7165@debian>
References: <20180730082804.20143-1-tiwei.bie@intel.com>
 <b16511e0-cbf6-0e65-df5a-dd6c6068f8b3@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: zhihong.wang@intel.com, dev@dpdk.org, stable@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <b16511e0-cbf6-0e65-df5a-dd6c6068f8b3@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 30, 2018 at 10:43:37AM +0200, Maxime Coquelin wrote:
> On 07/30/2018 10:28 AM, Tiwei Bie wrote:
> > Add the missing param "server" to param string.
> > Also add the missing spaces after params.
> > 
> > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> >   drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> > index 5ee59d5e5..525d16cab 100644
> > --- a/drivers/net/virtio/virtio_user_ethdev.c
> > +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
> >   	"cq=<int> "
> >   	"queue_size=<int> "
> >   	"queues=<int> "
> > -	"iface=<string>"
> > -	"mrg_rxbuf=<0|1>"
> > +	"iface=<string> "
> > +	"server=<0|1> "
> > +	"mrg_rxbuf=<0|1> "
> >   	"in_order=<0|1>");
> > 
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio/master, thanks.