From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chas Williams <3chas3@gmail.com> Subject: [PATCH] net/i40e: stop lldp before setting local lldp MIB Date: Wed, 1 Aug 2018 00:07:12 -0400 Message-ID: <20180801040712.13792-1-3chas3@gmail.com> Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, "Charles (Chas) Williams" To: dev@dpdk.org Return-path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id DA2755689 for ; Wed, 1 Aug 2018 06:07:41 +0200 (CEST) Received: by mail-qk0-f195.google.com with SMTP id c192-v6so11809722qkg.12 for ; Tue, 31 Jul 2018 21:07:41 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: "Charles (Chas) Williams" >>From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction Update: Starting from NVM 5.02, if the Set Local LLDP MIB command is received while the DCBx specific agent is stopped, the command returns an EPERM error. If the command is received while the LLDP agent is stopped, it sets the local MIB without exchanging LLDP with peer, and returns SUCCESS. This results in the harmless, but annoying, diagnostic: default dcb config fails. err = -53, aq_err = 1. So, always stop the lldp daemon when we are in software mode before we attempt to call i40e_set_dcb_config. Signed-off-by: Chas Williams --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index a340540ef..03bedf5c1 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -11237,6 +11237,7 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb) * i40e_init_dcb we expect is failure with I40E_AQ_RC_EPERM * adminq status. Otherwise, it should return success. */ + i40e_aq_stop_lldp(hw, TRUE, NULL); if ((ret == I40E_SUCCESS) || (ret != I40E_SUCCESS && hw->aq.asq_last_status == I40E_AQ_RC_EPERM)) { memset(&hw->local_dcbx_config, 0, -- 2.14.4