From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v1] net/mlx5: fix RSS flow configuration crash Date: Wed, 1 Aug 2018 16:13:44 +0200 Message-ID: <20180801141344.GH5211@6wind.com> References: <1533120218-32538-1-git-send-email-motih@mellanox.com> <1533130807-9183-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: shahafs@mellanox.com, dev@dpdk.org, nelio.laranjeiro@6wind.com To: Moti Haimovsky Return-path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id C39C87CD9 for ; Wed, 1 Aug 2018 16:14:01 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id a3-v6so20273677wrt.2 for ; Wed, 01 Aug 2018 07:14:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1533130807-9183-1-git-send-email-motih@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 01, 2018 at 04:40:07PM +0300, Moti Haimovsky wrote: > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as > negative numbers, queue numbers bigger than the number Rx queues the > PMD or has no queues at all. > > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Moti Haimovsky > --- > v1: > * Added check for zero queues. NACK until my previous comment regarding RTE_FLOW_ERROR_TYPE_ACTION_CONF is taken into account. -- Adrien Mazarguil 6WIND