From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: decrease log level for successful API
Date: Thu, 2 Aug 2018 08:14:44 -0700
Message-ID: <20180802081444.1211cf79@xeon-e3>
References: <1533213223-24028-1-git-send-email-ktraynor@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Kevin Traynor <ktraynor@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 881D51B4CE
 for <dev@dpdk.org>; Thu,  2 Aug 2018 17:14:47 +0200 (CEST)
Received: by mail-pg1-f194.google.com with SMTP id a11-v6so1348105pgw.6
 for <dev@dpdk.org>; Thu, 02 Aug 2018 08:14:47 -0700 (PDT)
In-Reply-To: <1533213223-24028-1-git-send-email-ktraynor@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  2 Aug 2018 13:33:43 +0100
Kevin Traynor <ktraynor@redhat.com> wrote:

> Change log level of messages from ERR back to DEBUG where
> existing API indicates that the condition is a success.
> 
> This means applications using the API in its current form will
> not get new ERR logs.
> 
> Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")

The expectations about level come from syslog:

       LOG_ERR        error conditions

       LOG_WARNING    warning conditions

       LOG_NOTICE     normal, but significant, condition

       LOG_INFO       informational message

       LOG_DEBUG      debug-level message

Therefore messages where an API did something wrong should be NOTICE
and messages where an API's normal action was successful should be
INFO or DEBUG.

All the "already XXX" messages should be NOTICE.