From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tiwei Bie <tiwei.bie@intel.com>
Subject: Re: [PATCH] vhost: suppress error if numa is not
	available
Date: Fri, 10 Aug 2018 11:03:27 +0800
Message-ID: <20180810030326.GA88853@debian.sh.intel.com>
References: <CGME20180809160856eucas1p2e22900aa2de83e9b17f5843151557d7b@eucas1p2.samsung.com>
 <1533830978-23518-1-git-send-email-i.maximets@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Zhihong Wang <zhihong.wang@intel.com>
To: Ilya Maximets <i.maximets@samsung.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 378AE25D9
 for <dev@dpdk.org>; Fri, 10 Aug 2018 05:05:53 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1533830978-23518-1-git-send-email-i.maximets@samsung.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


[PATCH] vhost: suppress error if numa is not available

s/numa/NUMA/

Otherwise check-git-log.sh [1] will complain:

Wrong headline lowercase:
        vhost: suppress error if numa is not available

Apart from that,

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

[1] https://github.com/DPDK/dpdk/blob/11a1f847d281/devtools/check-git-log.sh#L109

Thanks

On Thu, Aug 09, 2018 at 07:09:38PM +0300, Ilya Maximets wrote:
> It's a common case that 'get_mempolicy' fails on systems
> without NUMA support. No need to flag an error in log for
> this situation.
> 
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>  lib/librte_vhost/vhost.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index 3c9be10..91026b3 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -8,6 +8,7 @@
>  #include <stdint.h>
>  #include <stdlib.h>
>  #ifdef RTE_LIBRTE_VHOST_NUMA
> +#include <numa.h>
>  #include <numaif.h>
>  #endif
>  
> @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid)
>  	int numa_node;
>  	int ret;
>  
> -	if (dev == NULL)
> +	if (dev == NULL || numa_available() != 0)
>  		return -1;
>  
>  	ret = get_mempolicy(&numa_node, NULL, 0, dev,
> -- 
> 2.7.4
>