From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/2] hexdump: whitespace cleanup Date: Thu, 16 Aug 2018 09:59:41 -0700 Message-ID: <20180816095941.5acf7dbe@xeon-e3> References: <20180816153106.7608-1-stephen@networkplumber.org> <20180816153106.7608-2-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Wiles, Keith" Return-path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id 720304C6F for ; Thu, 16 Aug 2018 18:59:44 +0200 (CEST) Received: by mail-pl0-f66.google.com with SMTP id d5-v6so2384476pll.4 for ; Thu, 16 Aug 2018 09:59:44 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 16 Aug 2018 16:34:12 +0000 "Wiles, Keith" wrote: > I looked at the Coding Guide in section 1.7.2 and it states > > 1.7.2. Definitions > - The function type should be on a line by itself preceding the function. > - The opening brace of the function body should be on a line by itself. > > static char * > function(int a1, int a2, float fl, int a4) > { Really, I thought in general DPDK followed Linux kernel style. Making little exceptions like this is a nuisance.